Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme api 'toolbar_text' element changes color of toolbar text #44

Open
CharoSW opened this issue May 21, 2018 · 1 comment
Open

theme api 'toolbar_text' element changes color of toolbar text #44

CharoSW opened this issue May 21, 2018 · 1 comment

Comments

@CharoSW
Copy link
Contributor

CharoSW commented May 21, 2018

This may not seem like a bug by the title but for a static theme like this having elements that change color isn't great. However, as there may be situations where someone might want a to use a theme api extension (such as another extension that can tap into that api) completely setting the color of elements would probably be useful

@lunakurame lunakurame added this to the Firefox 60 milestone Jun 5, 2018
@lunakurame
Copy link
Owner

Currently we don't support themes other than the default one, but it actually sounds like a good idea. I think those lightweight themes can also change icon colors (a CSS variable --lwt-text-color also changes icon's fill color), so if we lock it in our theme, we might be able to finally solve that old problem with icon colors being swapped on random machines.

I'll read more about the theme API and try to implement this later, thanks.

@rafaelmardojai rafaelmardojai removed this from the Firefox 60 milestone Apr 20, 2019
andrew-ls pushed a commit to andrew-ls/firefox-gnome-theme that referenced this issue Oct 15, 2019
andrew-ls pushed a commit to andrew-ls/firefox-gnome-theme that referenced this issue Oct 15, 2019
andrew-ls pushed a commit to andrew-ls/firefox-gnome-theme that referenced this issue Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants