Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update download url #1689

Merged
merged 3 commits into from Nov 28, 2017
Merged

Update download url #1689

merged 3 commits into from Nov 28, 2017

Conversation

lhw828
Copy link
Contributor

@lhw828 lhw828 commented Nov 26, 2017

No description provided.

@lunar-linux-b01
Copy link

SUCCESS!

dagbrown
dagbrown requested changes Nov 28, 2017
View reviewed changes
Copy link
Member

@dagbrown dagbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work.

If you have a SOURCE_URL[1], then you need to change the first SOURCE_URL to be SOURCE_URL[0].

@lunar-linux-b01
Copy link

SUCCESS!

dagbrown
dagbrown requested changes Nov 28, 2017
View reviewed changes
Copy link
Member

@dagbrown dagbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No no, the first URL should be SOURCE_URL[0], the second url should be SOURCE_URL[1].

Look at what you did in the lvm2 module, you did it right there.

@lunar-linux-b01
Copy link

SUCCESS!

@Ratler Ratler merged commit a5161e7 into lunar-linux:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagbrown dagbrown dagbrown requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lhw828 @lunar-linux-b01 @dagbrown @Ratler