-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Playdate support to stds #70
Conversation
Is there anything I can do on my end to investigate the unit test failures? I'm currently getting 3 errors on my PR branch:
and 2 warnings:
|
I don't see any test failures or lint warnings at all. What/where/how are you running tests that show those? I started to review this earlier today. I didn't get all the way through it but I think the biggest barrier is probably adjusting the commit messages to something conventional commits compatible so this shows up in the release notes correctly. I didn't see anything major that needed changing before merging. |
I can absolutely redo the commit messages, maybe resubmit this as a new PR with just one commit? I get the errors when I run
Is there some kind of a local state that could affect my result versus yours? |
No need need for a different PR, we can rebase this one just fine. I can even handle it with |
Didier, one question on the test failures- are you running with luajit? The luajit test runner seems to have occasional test failures when run via CI, see e.g. discussion in #46 |
Not sure. How do I check for that? |
I don't know if you can get it out directly, but you can explicitly pass a lua binary to busted to use. i.e. |
Sure you can, like this: $ busted -e 'print(jit and jit.version or _VERSION)' |
I get just plain Lua 5.4 |
I can repro this, the issue is that you don't have luasocket installed. Try
I can't repro these, but from the context and the test names I'm wondering if you have luafilesystem installed. (When I uninstall it to test, busted itself breaks; but you may have gotten busted a different way.) We should probably add explicit documentation for running the tests, right now the luasocket requirement in particular seems to be both undocumented and invisible, since the failing test only checks the return code. |
Thanks for ferreting out that info @arichard4 that's helpful. As I understand it this PR is actually good to be merged and those failures are all local to Didier's testing setup. Tests pass in CI and for me locally and I don't see any other reason to hold up merging this. Am I missing anything? |
Nope, this PR looks good to me. |
These were found by running luacheck against the SDK’s sample code.
I revised the Git commit messages to be conventional commits compliant, but otherwise no change... Thanks for the contribution @DidierMalenfant! |
Following conversation #68 with @alerque, here is a first pass at adding support for the Playdate SDK as an stds option.
I have one test failing when running
busted
but the same test fails in the main branch too so I'm assuming that's not my fault.I tested it against my code and the sample code found in the SDK and also by merging it with #66 which seems to be working fine.
I, for now, decided not to add any instance methods because they are mostly called via
instance:methodName()
which luacheck wouldn't catch (AFAIK) and thought it may also help catch incorrect calls likeinstance.methodName()
.Let me know how this looks. Comments/criticism are welcome.