Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Method remove into ShippingModifiers #1600

Merged
merged 3 commits into from
May 6, 2024

Conversation

lguichard
Copy link
Contributor

The ShippingModifiers store modifiers in collection, the method remove tried to remove the key that didn't exist.

Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 8:00pm

Copy link
Collaborator

@alecritson alecritson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a new test or to tweak an existing one?

@lguichard
Copy link
Contributor Author

Do we need a new test or to tweak an existing one?

That's it ;-)

@glennjacobs glennjacobs added this to the v0.8 milestone Mar 4, 2024
@glennjacobs glennjacobs merged commit 98474d9 into lunarphp:0.8 May 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants