Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Method remove into ShippingModifiers #1600

Merged
merged 3 commits into from
May 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/Base/ShippingModifiers.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ public function add($modifier)
*/
public function remove($modifier)
{
$this->modifiers->forget($modifier);
$this->modifiers = $this->modifiers->reject(fn ($value) => $value == $modifier);
}
}
61 changes: 61 additions & 0 deletions packages/core/tests/Unit/Base/ShippingModifiersTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
<?php

namespace Lunar\Tests\Unit\Base;

use Illuminate\Foundation\Testing\RefreshDatabase;
use Lunar\Base\ShippingModifier;
use Lunar\Base\ShippingModifiers;
use Lunar\Models\Cart;
use Lunar\Models\Currency;
use Lunar\Tests\TestCase;

class ShippingModifiersTest extends TestCase
{
use RefreshDatabase;

private Cart $cart;

private ShippingModifiers $shippingModifiers;

private ShippingModifier $class;

public function setUp(): void
{
parent::setUp();

$currency = Currency::factory()->create([
'decimal_places' => 2,
]);

$this->cart = Cart::factory()->create([
'currency_id' => $currency->id,
]);

$this->class = new class extends ShippingModifier
{
public function handle(Cart $cart)
{
//
}
};

$this->shippingModifiers = new ShippingModifiers();
}

/** @test */
public function can_add_modifier()
{
$this->shippingModifiers->add($this->class::class);

$this->assertCount(1, $this->shippingModifiers->getModifiers());
}


public function can_remove_modifier()
{
$this->shippingModifiers->remove($this->class::class);

$this->assertCount(0, $this->shippingModifiers->getModifiers());
}

}
Loading