Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breadcrumbs): make winbar_filetype_exclude customizable #3221

Merged
merged 1 commit into from Oct 13, 2022

Conversation

abzcoding
Copy link
Member

i want to be able to exclude noice, notify and ... filetypes from breadcrumbs

@abzcoding abzcoding requested a review from vonPB October 13, 2022 11:26
@abzcoding abzcoding changed the title fix(breadcrumbs): make winbar_filetype_exclude is customizable fix(breadcrumbs): make winbar_filetype_exclude customizable Oct 13, 2022
@abzcoding abzcoding requested review from ChristianChiarulli and vonPB and removed request for vonPB October 13, 2022 11:36
@abzcoding abzcoding merged commit 09cbce4 into LunarVim:rolling Oct 13, 2022
@vonPB
Copy link
Member

vonPB commented Oct 13, 2022

I've never tried noice before. Checked this pr out and added noice to the plugins and got a bunch of errors on every command.
But should not be related to this specific problem though.
image

@abzcoding
Copy link
Member Author

abzcoding commented Oct 13, 2022

I've never tried noice before. Checked this pr out and added noice to the plugins and got a bunch of errors on every command.
But should not be related to this specific problem though.

look at my commit messages,
it does exactly have to do with this, just add vim to the excluded list
since noice uses vim filetype for it's cmdline
abzcoding/lvim@66378a1

@vonPB
Copy link
Member

vonPB commented Oct 13, 2022

Ah! Great that works.
Just had to remove the and lvim.builtin.noice.active
Thanks @abzcoding

tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Oct 14, 2022
* upstream/rolling: (50 commits)
  fix: name treesitter source in cmp (LunarVim#3223)
  fix(breadcrumbs): make sure winbar_filetype_exclude is customizable (LunarVim#3221)
  fix: typo in git.lua
  fix: Remove J and K key mappings for move (LunarVim#3206)
  fix(lua-dev): make sure we are loading the correct types (LunarVim#3208)
  chore: bump nvim-tree.lua version to `b01e7be` (LunarVim#3203)
  chore(illuminate): pcall for configure
  fix(plugins): set max jobs to 50 on mac
  feat(uninstaller): desktop entry
  Feat(installer): desktop entry (LunarVim#3187)
  fix(lualine): globalstatus=true by default
  fix: use function for pickers
  feat(cmp): add configs for cmp.setup.cmdline (LunarVim#3180)
  fix(typo): fix language server name typo in config example LunarVim#3176 (LunarVim#3183)
  feat: warn user when setting un-installed colorscheme (LunarVim#2982)
  fix: move telescope.actions pcall to the top
  fix(installer): don't set log level
  fix(lualine): guard setup on install (LunarVim#3185)
  fix: telescope delete_buffer binds correct scope
  Add: Workflow to stale/close inactive issues | Fixes LunarVim#3168 (LunarVim#3177)
  ...
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Oct 19, 2022
* upstream/master: (139 commits)
  chore: update changelog
  feat(config): allow disabling reload-on-save (LunarVim#3261)
  fix: nil table in breadcrumbs in autocommand (LunarVim#3267)
  docs: Update contributing readme with new url for install docs. (LunarVim#3254)
  fix: disable unsupported asian characters spellchecking (LunarVim#3259)
  fix: copilot background should matcha statusline
  fix: disable gitsigns hunk navigation message (LunarVim#3244)
  chore(plugins): bump version (LunarVim#3248)
  perf(plugins): move assert `vim.env.LVIM_DEV_MODE` logic (LunarVim#3238)
  fix(nvim-cmp-lsp): update_capabilities has been deprecated (LunarVim#3245)
  fix(luadev): this plugin has been renamed (LunarVim#3235)
  fix: don't install desktop file w/o xdg-desktop-menu (LunarVim#3229)
  fix(alpha): check alpha module (LunarVim#3233)
  feat: latest impatient updates from upstream (LunarVim#3236)
  fix: name treesitter source in cmp (LunarVim#3223)
  fix(breadcrumbs): make sure winbar_filetype_exclude is customizable (LunarVim#3221)
  fix: typo in git.lua
  fix: Remove J and K key mappings for move (LunarVim#3206)
  fix(lua-dev): make sure we are loading the correct types (LunarVim#3208)
  chore: bump nvim-tree.lua version to `b01e7be` (LunarVim#3203)
  ...
@abzcoding abzcoding deleted the fix/breadcrumbs branch October 22, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants