Parse shuttle.yaml and plan.yaml strictly #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we silently ignore unknown fields in shuttle.yaml and plan.yaml. This can lead to odd behaviour and hard to find bugs from typos. This change adds strict parsing of shuttle.yaml and plan.yaml failing commands if any unexpected fields are found.
mahlunar
approved these changes
Mar 23, 2021
|
I don't understand @mahlunar ? |
The comment is not really part of this PR so let's ignore it here. The exitCode error type might be better off with another name as I misinterpreted it as an os exit code call. |
|
Ah I see. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we silently ignore unknown fields in shuttle.yaml and plan.yaml. This
can lead to odd behaviour and hard to find bugs from typos.
This change adds strict parsing of shuttle.yaml and plan.yaml failing commands
if any unexpected fields are found.
Closes #3.