Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in plan configuration decoding #69

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

Crevil
Copy link
Member

@Crevil Crevil commented Mar 25, 2021

Currently shuttle cannot use plans with shared variables set in the "vars"
section. This is a bug introduced in 89c04a2 (#64) where we enabled strict parsing.

This change allows the usage of "vars" in plan.yaml configuration files.

Currently shuttle cannot use plans with shared variables set in the "vars"
section. This is a bug introduced in 89c04a2
(#64) where we enabled strict parsing.

This change allows the usage of "vars" in plan.yaml configuration files.
@Crevil Crevil requested a review from a team March 25, 2021 19:58
Copy link
Member

@kaspernissen kaspernissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\lgtm
Nice 🚀

@Crevil Crevil merged commit 7b0b0c1 into master Mar 26, 2021
@Crevil Crevil deleted the fix/plan-config-vars-decoding branch March 26, 2021 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants