Support shuttle commands from sub directories #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when shuttle is invoked it needs to be in the root of a project. This limits its uses in scripts like go:generate where files in sub directories would rely on the root project path. This change adds a recursive lookup of the project path by walking backwards in the file tree to find a shuttle.yaml file. This is a well known pattern from other CLIs like Git where a CLI command from a sub directory acts as if it was invoked from the project root.
|
A test case is failing where the I think we should disable the traversal when using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when shuttle is invoked it needs to be in the root of a project. This
limits its uses in scripts like go:generate where files in sub directories would
rely on the root project path.
This change adds a recursive lookup of the project path by walking backwards in
the file tree to find a shuttle.yaml file. This is a well known pattern from
other CLIs like Git where a CLI command from a sub directory acts as if it was
invoked from the project root.