Coroutine build failed with error C7651

[LilyWangL]

I am a member of Microsoft VCPKG team. In an internal version of Visual Studio, coroutine build failed with error C7651:

buildtrees\coroutine\src\1.5.0-36192178c9.clean\modules\portable\frame.cpp(136): error C7651: __builtin_coro_resume cannot be used with /await. Use '/std:c++latest' or later for standard coroutine support
buildtrees\coroutine\src\1.5.0-36192178c9.clean\modules\portable\frame.cpp(144): error C7651: __builtin_coro_destroy cannot be used with /await. Use '/std:c++latest' or later for standard coroutine support

This issue due to an internal change in compiler. For fixing this issue, we need to introduce a set of wrapper functions in frame.cpp so that the calls to __builtin_coro_* only appear in templates with a value-dependent condition. Then in the portable_coro_(done|resume|destroy) functions replace the call to __builtin_coro_* with a call to the appropriate wrapper with a template argument <true>.
I have added a patch to solve this problem temporarily on VCPKG, the related PR microsoft/vcpkg#12456. I submit this issue and want to fix this error on upstream.

Thanks a lot.

[luncliff]

Thanks for let me know! I will take a look and fix it this weekend.

…

On Fri, Jul 17, 2020, 12:20 PM Lily ***@***.***> wrote: I am a member of Microsoft VCPKG team. In an internal version of Visual Studio, coroutine build failed with error C7651: buildtrees\coroutine\src\1.5.0-36192178c9.clean\modules\portable\frame.cpp(136): error C7651: __builtin_coro_resume cannot be used with /await. Use '/std:c++latest' or later for standard coroutine support buildtrees\coroutine\src\1.5.0-36192178c9.clean\modules\portable\frame.cpp(144): error C7651: __builtin_coro_destroy cannot be used with /await. Use '/std:c++latest' or later for standard coroutine support This issue due to an internal change in compiler. For fixing this issue, we need to introduce a set of wrapper functions in frame.cpp so that the calls to __builtin_coro_* only appear in templates with a value-dependent condition. Then in the portable_coro_(done|resume|destroy) functions replace the call to __builtin_coro_* with a call to the appropriate wrapper with a template argument <true>. I have added a patch to solve this problem temporarily on VCPKG, the related PR microsoft/vcpkg#12456 <microsoft/vcpkg#12456>. I submit this issue and want to fix this error on upstream. Thanks a lot. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#51>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADLSYEYZSIOXQHM4UJ7ZOZTR367RNANCNFSM4O5NG4QQ> .