Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[coroutine] Fix error C7651 #12456

Merged
merged 2 commits into from
Aug 1, 2020
Merged

Conversation

LilyWangL
Copy link
Contributor

@LilyWangL LilyWangL commented Jul 17, 2020

Describe the pull request

F:\0712\buildtrees\coroutine\src\1.5.0-36192178c9.clean\modules\portable\frame.cpp(136): error C7651: __builtin_coro_resume cannot be used with /await. Use '/std:c++latest' or later for standard coroutine support
F:\0712\buildtrees\coroutine\src\1.5.0-36192178c9.clean\modules\portable\frame.cpp(144): error C7651: __builtin_coro_destroy cannot be used with /await. Use '/std:c++latest' or later for standard coroutine support
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    No
  • Does your PR follow the maintainer guide?
    Yes

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 17, 2020
@LilyWangL LilyWangL added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jul 20, 2020
@Cheney-W Cheney-W marked this pull request as ready for review July 27, 2020 02:13
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jul 27, 2020
@strega-nil
Copy link
Contributor

We should let @luncliff fix this, instead of doing a hacky workaround, imo.

@strega-nil strega-nil added depends:upstream-changes Waiting on a change to the upstream project and removed requires:discussion info:reviewed Pull Request changes follow basic guidelines labels Jul 30, 2020
@luncliff
Copy link
Contributor

luncliff commented Aug 1, 2020

Sorry for the really late response @LilyWangL.
My conclusion about the issue is that I have to survey available compilers again, then make some preparation for the kinds of issues.
I couldn't find a better way than the patch.

After merge of the PR, I will merge the patch in my next release.

@strega-nil
Copy link
Contributor

Given that @luncliff thinks that this patch is the best way forward, I'm okay with merging it.

@strega-nil strega-nil merged commit 8797e9b into microsoft:master Aug 1, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* [coroutine] Fix error C7651

* Update portfile.cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants