Kitchen sink #3
Merged
Kitchen sink #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only pluto
see comment below
lungben
approved these changes
Sep 15, 2020
docker/precompiled/Dockerfile
Outdated
| ENV JULIA_DEPOT_PATH ${USER_HOME_DIR}/.julia | ||
| ENV NOTEBOOK_DIR ${USER_HOME_DIR}/notebooks | ||
| ENV JULIA_NUM_THREADS = 100 | ||
| ENV JULIA_NUM_THREADS=100 |
There was a problem hiding this comment.
I have just seen that using "=" for variable assignment in Dockerfile does not work.
This line should be changed to
ENV JULIA_NUM_THREADS 100
Same for here:
ENV DEBIAN_FRONTEND noninteractive
For the non-precompiled Docker image I just corrected it.
There was a problem hiding this comment.
thanks! no wonder it wasn't picking up 😅
|
Docker repo name is to be updated from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fonsp#13 (comment)