Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty decimals #45

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Fix empty decimals #45

merged 1 commit into from
Feb 28, 2020

Conversation

jayuuza
Copy link

@jayuuza jayuuza commented Feb 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #45 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   38.54%   38.42%   -0.12%     
==========================================
  Files           7        7              
  Lines         672      674       +2     
==========================================
  Hits          259      259              
- Misses        390      392       +2     
  Partials       23       23
Impacted Files Coverage Δ
decimal/decimal.go 90.35% <0%> (-1.62%) ⬇️
api.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e28275...e98388b. Read the comment docs.

neilgarb
neilgarb approved these changes Feb 28, 2020
View reviewed changes
Copy link
Collaborator

@neilgarb neilgarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilgarb neilgarb merged commit 4e4d2c1 into luno:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilgarb neilgarb neilgarb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayuuza @neilgarb