[pull] master from chromium:master #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
We will reuse this class in WebLayer so that the metrics that it captures are available there. Change-Id: I819608fdf99c9411c995a9a1707997c55611bd3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198260 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/main@{#928140}
…y::GetBucket to avoid an async post task and go directly to the mock manager. This matches other overridden MockQuotaManagerProxy functions for the same purpose. Bug: 1248102 Change-Id: Ib5813e80c86c01a444f31a7725efbaa509fb5f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187531 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Ayu Ishii <ayui@chromium.org> Commit-Queue: Brian Begnoche <bcb@chromium.org> Cr-Commit-Position: refs/heads/main@{#928141}
Roll Chrome Mac PGO profile from chrome-mac-main-1633413357-8d6c393c75db4dbbae1fb957c5485260c6a320eb.profdata to chrome-mac-main-1633433674-69106135b2d7a5438cfa1b542c69e71e2a76b5e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5dc676c67ab6daefe1c7fc90cf122578721a482f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205951 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928142}
Roll Chrome Win64 PGO profile from chrome-win64-main-1633424041-8cc5ea252804106c79dd19c5f07beb584760c7f0.profdata to chrome-win64-main-1633433674-db518b4b163260b888750cb911f527f7391e19ca.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iccc8e9e60cd5924e4ee041670e95244efff08c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205467 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928143}
The current implementation of DeleteAllTestingProfiles() doesn't remove profiles from an underlying ProfileManager. ProfileManager keeps profiles in the ProfileInfoMap. All other Delete*Profile() methods in TestingProfileManager do actually delete a profile by erasing a ProfileInfo entry in the ProfileManager. This CL applies the same method to DeleteAllTestingProfiles(). This CL also fixes tests that start failing because DeleteAllTestingProfiles() actually deletes profiles now. Change-Id: I81c45b55701f2393246a68fc07c09e1fb7ad21d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198888 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/main@{#928144}
Change-Id: I40f952467c2214992fcf2b6c32d3bf843a3b0fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201970 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#928145}
Roll Chrome Win32 PGO profile from chrome-win32-main-1633424041-c92a3aacc47e6fc7e43e3b4805f748ab98dd9301.profdata to chrome-win32-main-1633433674-9794f1f065a20cda1d4d472d31d649e95d672adc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If8c40763b5d537c3dd2cd314989d0c33cb1fa3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205538 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928146}
Before this CL, we manually intervened on behalf of fenced frames, in the WebIDL implementation of DOMWindow::top() and DOMWindow::parent(), to honor the "fence" in fenced frames, and not return Window references outside the fence. These changes were appropriate, but very locally-scoped. Both parent() and top() delegate to their respective methods in both FrameTree and Frame, and there are some other uses of these methods in Blink where we also want to honor the fenced frame's "fence". This CL modifies FrameTree::Parent()/Top() and Frame::Parent()/Top() to take in bools that default to false, that indicate whether or not we should honor the fenced frame's "fence", should we come across it. We get to localize the logic that honors the fence to `Frame::Parent()`, which is a deduplication of the previous implementation. This also makes it easier to trigger the fence-honoring logic wherever needed, by allowing callers to explicitly pass in `true` to either of these methods. The fenced frames team will be performing an audit [1] of all of their usages in Blink to determine which ones need to honor the fence and which do not. [1]: https://docs.google.com/spreadsheets/d/1wFJBhskdi3K5dVg13i_hbk_aKcqY7BOEHBZbnRSdgwk/edit#gid=0 R=dcheng@chromium.org Bug: 1123606 Change-Id: Icdccc356f5c29874e7be57a451cf1bf942d0e6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199540 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#928147}
Explain that it is not a hard limit on cache size but a hint used by different cache subsystems. BUG=1064308 Change-Id: I161cff408853857a531ace7f35110f2cc9e67790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205851 Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/main@{#928148}
Bug: 1256770 Change-Id: I37cdb5c709aa5e75f5b2cde0ab177fc89f9bbe70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205415 Auto-Submit: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/main@{#928149}
AccountsReloadingTest#testRefreshTokenUpdateWhenSignedInUserAddsNewAccount is flaky on all Android versions. Bug: 1254405 Change-Id: I45440efb00729f64991f4bdafacf393397d24d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205200 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/main@{#928150}
The desugared version accesses "dark greylist" APIs, which cause a modal dialog to show up in instrumentation tests on Android P. Bug: 1256614 Change-Id: I62e015fa19b51e52a2393e228ee5fad60f50243f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205912 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/main@{#928151}
This is a reland of 6fd6599 Original change did not correctly handle the case with gpu fence and read lock fence. (Patchset 1 vs 4) CI issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1253576 Original change's description: > Propagation of overlays to SkiaRenderer for backing release > > Just like MacOS, LaCros delegated compositing requires released > overlays to propagate back to SkiaRenderer in order to release the > backings for the aggregate render passes. > > This propagation follows the mac code closely with the exception of the > special case handling for solid color quads. > > Bug: 1203921 > Change-Id: Iba09e2b2e17d2dc554d0936bb0427a8ae58b6e9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3171533 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Kramer Ge <fangzhoug@chromium.org> > Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> > Cr-Commit-Position: refs/heads/main@{#924860} Bug: 1203921 Change-Id: If37f6f731cae880d9ec3ab430db25ae3dd44e447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193374 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: Kramer Ge <fangzhoug@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/main@{#928152}
The check for a containing render process host was not updated for inner frame trees. It turns out that a check in RenderFrameHostImpl::CreateNewPopupWidget already covers this situation and is more accurate checking the frame tree state so the problematic code can be removed. BUG=1123606 Change-Id: I97f222e625a5466524586417aaa923deab91d22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193214 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#928153}
Handle pointer motion event generated by libinput, extract motion's delta ‘x’ and ‘y’, and notify the upper stack layer. Bug: b:192669240 Change-Id: Ibe840db3f93e090584a76a513662cf2ec4177adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141594 Reviewed-by: Harry Cutts <hcutts@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/main@{#928154}
https://android.googlesource.com/platform/external/perfetto.git/+log/a94219a7a993..5df0557c091d 2021-10-05 primiano@google.com Improve SDK release docs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7b145ddda8e7e255925499efd4ca6823a5951876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205541 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928155}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c568467eddd2..5ed3f14f99e7 2021-10-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-10-05 szuend@chromium.org [sync] Add syncable storage to Settings instance 2021-10-05 tross@microsoft.com [Accessibility]: Set title for grid/flex overlay color picker 2021-10-05 szuend@chromium.org Replace trivial getters with public readonly properties in Setting If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1245541,chromium:1255963 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie834c7b4a7ee4a71bbe8c8090ef3dd29b387081e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205652 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928156}
https://android.googlesource.com/platform/external/perfetto.git/+log/434f1f8e22ca..a94219a7a993 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6d59cac0c0d2ed2cd6be76b77a62a749bbd5ac53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205952 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928157}
Remove a double entry that was present in the auto imports list used for the Polymer3 migration. Change-Id: I981082261df82e96a612d0e3ad282bf7fa0bef2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206010 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/main@{#928158}
In certain cases, such as background-color: Field, we are not able to get the color of all keyframes, in this case, we should not composite the background-color animation, and instead make it run on the main thread. Bug: 1255402 Change-Id: I53aa957885051d488439602c0969f4be54d86325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202514 Reviewed-by: Kevin Ellis <kevers@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/main@{#928159}
This is part 1 of a series of 3 changes: 1. Add interfaces for the credential manager launcher (upstream) 2. Add implementation for the credential manager launcher (downstream) 3. Add public implementation for the credential manager launcher and exclude implementations from the jar so that upstream and downstream can explicitly provide their own version of the implementation (upstream) Bug: 1255038 Change-Id: I697d82c269bf64d82835a97c5b1f0a250199c3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205199 Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/main@{#928160}
Bug: 1225308 Change-Id: Ib4dd012850f6a741e3610e4622d6bbbc48ba62f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3054862 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/main@{#928161}
These tests prod internals (which they shouldn't) and will be replaced by e2e-tests instead. R=yangguo@chromium.org CC=marijnh@gmail.com Bug: 1241848 Change-Id: I692a6aa2bbaa6ac7c52f2a423b572fd84e0b8a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205515 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/main@{#928162}
This change: * Adds the `kPreflightWarn` and `kPreflighBlock` private network request policies. * Introduces two new feature flags controlling the rollout of the new policies. * Modifies `network::PrivateNetworkAccessCheck()` to handle the new policies. * Adds unit tests for `network::URLLoader` to check this handling. * Adds browser tests to content/browser/renderer_host/private_network_access_browsertest.cc Fixed: chromium:1251963 Change-Id: Ice0990bc8caa47977846e70a4e63c5dfe01add28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3179212 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/main@{#928163}
It is constexpr and only used locally. This is a fixup of https://crrev.com/c/1251361 Bug: none Change-Id: Id7d644ddfa39281657bb5b6f7f256c5c7de25776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3177669 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Primiano Tucci <primiano@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/main@{#928164}
Safe Browsing Module services uses SafeBrowsingMetricsCollector and prefs to decide if a module is visible to the user. It counts when the module has been shown previously to initiate a cooldown if required. Add GetLatestSecuritySensitiveEventTimestamp to safe_browsing_metrics_collector Bug: 1240291 Change-Id: Ic9c32abb45bc3ea2bdfb050fcc69694a1f1c45b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3176980 Commit-Queue: Rohit Bhatia <bhatiarohit@google.com> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/main@{#928165}
Bug: 1255114 Change-Id: I97ebbca1f9f6b0e2c9fa5b04b6d868940613ec60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205913 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#928166}
Oscillator only kept a weak reference to PeriodicWave to avoid cycles with the PeriodicWave holding the OscillatorNode alive (e.g. via JavaScript interactions). Using a cross-thread weak reference requires converting it into a strong reference throuhg CrossThreadWeakPersistent<>::Lock(). Creating a new cross-thread handle interferes with garbage collection on the thread owning PeriodicWave. This CL provides a different solution in splitting up PeriodicWave into a scriptable part and PeriodicWaveImpl which purely holds data. This way, OscillatorHandler can refer to PeriodicWaveImpl via a strong cross-thread reference which avoids conversions that can interfere with the GC. In addition, this also generally speeds up the kernel as it also saves on creating a strong from a weak handle. Bug: chromium:1252743 Change-Id: I2c3de2021428f1cff488bc4af73230c7e5ac229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192679 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#928167}
Bug: b:177878025 Change-Id: I40d95d4c6e338975c19d262b214ab294d5deead4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202730 Reviewed-by: Hugo Benichi <hugobenichi@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Taoyu Li <taoyl@chromium.org> Cr-Commit-Position: refs/heads/main@{#928168}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/37e7065ef789..d77a45b9da5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC gogerald@google.com,sauski@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1256675 Tbr: gogerald@google.com,sauski@google.com Change-Id: Ie0a747e716b43a4ed63ad755b152d145ec571cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205954 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928169}
We have migrated camera app to SWA since M88. But during the time, we still install the legacy camera app first for users who haven't migrated camera app and use "Uninstall and Replace" mechanism to migrate the pinned status to SWA. Since it has been about 8 milestones, it should be safe to remove such mechanism to unblock the other projects and simplify the logic. Bug: b:202082286 Test: Manually Change-Id: I639307fd3ac7ccd4c58fcc886eee2355351d8e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203994 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Reviewed-by: Dominic Schulz <dominicschulz@google.com> Reviewed-by: Shik Chen <shik@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#928269}
This is untested, other than to verify Chrome still works, since nothing in chrome/ actually uses the color provider for a custom-theme-controlled color yet. As a side effect, this sets the native theme for bubbles in sync with the anchor widget, which fixes bug 1028824. Bug: 1028824, 1003612 Change-Id: I69ea3147b34bd84e80c33f9c5bbfbec887db4900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3190915 Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/main@{#928270}
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/3b49be074d5c..075810f7a204 2021-10-05 dino.radakovich@gmail.com Merge pull request #3581 from cclauss:codespell If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/googletest-chromium-autoroll Please CC asully@google.com,preethim@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win-chrome Tbr: asully@google.com,preethim@google.com Change-Id: I7c9238efdc52c4672ad5ecef8d0982c694a834fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205601 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928271}
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/03cba6fa..a5e9d08e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel R=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic64fb8465e77bc45fa0b1274afa9519036bab42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206311 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928272}
This data structure allows CookieMonster to query cookies from multiple partitions. We would not let a request or a site's script query for multiple partitions, but there are several CookieManager use cases that need to be able to query multiple partitions such as site settings and DevTools. The set needs the ability to match no partition keys, a single key, multiple keys, or all possible keys. One use for the last case is displaying all partitioned cookies belonging to a site in settings. Since HTTP requests and RestrictedCookieManager will be restricted to a single cookie partition key, and that special case will be common, I added special logic to CookiePartitionKeySet to handle that case more efficiently than querying multiple partition keys. Bug: 1225444 Change-Id: I8cd5b8be44e87518ad48da1109671b9ef5dcfd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198713 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Maksim Orlovich <morlovich@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/main@{#928273}
Bug: 1256861 Change-Id: I9f18ad4a3c97186f4d683f40a1903a52549d5ddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206532 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Owners-Override: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/main@{#928274}
Change-Id: Ibdbe896fd2b2afad7ee0e7cdd4da67a0aa6c82f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206450 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/main@{#928275}
I removed the files in core/loader/appcache/* as well as the core/events/application_cache_error* code, and then fixed up the callers of this code. I will follow up and remove the worker plumbing, but this patch is already large enough. Bug: 582750 Change-Id: I40528f60c9cd12f8ace9d7b31950d0753e2ea2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200317 Commit-Queue: enne <enne@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#928276}
Callbacks for pending requests will not be invoked when the key fetcher gets deleted. This CL adds a test to verify this behavior. This CL also implements the functionality for MockNetworkFetcher to run the callback asynchronously. Bug: 1254948 Change-Id: I415a6f69c36a0eafed73b2b7a8571bc1ae79e848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3202113 Reviewed-by: Alex Turner <alexmt@chromium.org> Reviewed-by: Andrew Paseltiner <apaseltiner@chromium.org> Commit-Queue: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#928277}
Change-Id: I62caf8ceca9c69eb8b1ca6a1c966bbf375698859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204230 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/main@{#928278}
Add gordonseto@google.com to OWNERS for ash/system/bluetooth/. Change-Id: Idcbdc2d43c2ce8d234dde62e2847b8dce4526f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206483 Commit-Queue: Gordon Seto <gordonseto@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Gordon Seto <gordonseto@google.com> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/main@{#928279}
Bug: 1251733 Change-Id: I01f44b81183ac105e9253f71f5a8ff9fc996bf62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204517 Auto-Submit: ssid <ssid@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Reviewed-by: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/main@{#928280}
This makes the names consistent with the usage in https://chromium.googlesource.com/chromium/src/+/refs/heads/main/gin/v8_initializer.cc#70 BUG=764576 TEST=none Change-Id: Ifdf295a025b58ff72e356eef02d6359b53eb0837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201045 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/main@{#928281}
This CL hides the sync consent screen when signed-out users back press for the project MICe. Bug: 1252300 Change-Id: Ic256f1f7fcc250e10792700fcafd1bf6b66e5c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3178380 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/main@{#928282}
In http://crrev.com/925413 I fixed a very similar Range loop in DisplayLockUtilities, but I forgot to update the other loop in DisplayLockDocumentState. This patch updates the DisplayLockDocumentState Range loop to match the newer DisplayLockUtilities one. This patch fixes the attached clusterfuzz test case, but I'm not including a test case because the clusterfuzz test doesn't have a minimal repro. Ideally I would make these loops share the same code, but I couldn't figure out an elegant way to do so. I could make a function that takes a lambda, but the usage in DisplayLockDocumentState wants to return out of the top level function in the middle of the loop, which I don't think I could do from a lambda. I could try to make my own Iterator class for this... thoughts? Fixed: 1255155 Change-Id: I23025a52cd23b4a1a49b48def40fd016f42edbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205667 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#928283}
Fixed: 1254723 Change-Id: If71d2bdad82866e42fad43bfe1d8ad795475f3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198210 Commit-Queue: Abigail Klein <abigailbklein@google.com> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/main@{#928284}
Now that https://dawn-review.googlesource.com/c/dawn/+/65664 has landed, Chrome can use "feature" instead of "extension" when appropriate. Change-Id: I5ae1d1ad670e9b594cca662d3b1cb0b14eb7b890 Bug: dawn:1149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205514 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Maggie Chen <magchen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#928285}
Bug: 1254332 Change-Id: I94ad9f865960bc18f2bf99725f5464d24b954949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206251 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/main@{#928286}
This CL addresses current issues with focus in the side panel. Specifically this CL allows the side panel to request focus when opened via the toolbar button but not when it is opened as a result of switching to a tab where the side panel is opened. The SideSearchBrowserController uses an ExternalFocusTracker to keep track of the last focused view and will restore focus to this view when the side panel is closed. This fixes current behavior where focus would move to the next available view in focus order when closed (focus was always moved into the security chip). This CL also prevents the side panel from auto-reopening when the user has gone from non-Google page with side panel open Google SRP (or similar) where the panel auto closes another non-Google page where the side panel currently auto reopens In the new flow (in the state-per-tab model) the side panel would not reopen for the last navigation. Fixes to propagation of user prefs and task manager ids have also been bundled into this CL. Bug: 1236631 Change-Id: I7ff7153d8f8c51b8278b62592270cd2eaf15c1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3200397 Reviewed-by: Yuheng Huang <yuhengh@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/main@{#928287}
This is a reland of cba0b68 Original change's description: > Enable passthrough on Android for tests > > Bug: 1157073,1253930,1253927 > Change-Id: Id2fc2927f5a45181470b4fe335cb124ccbddbfb9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3187671 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/main@{#925833} Bug: 1157073,1253930,1253927 Change-Id: I3ebfd2302776f29e72ac7404b05527bf17fc0fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203572 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#928288}
Bug: 1051793 Change-Id: Ie6d284a944ff31469be5148033728af941559c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198041 Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Dodd <gavindodd@google.com> Cr-Commit-Position: refs/heads/main@{#928289}
Bug: 1234182 Change-Id: I224364728bc12d44afa6307251413dcbb8e69024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3204094 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#928290}
This unblocks finch trial in the M95 Beta channel. Bug: 1236283 Change-Id: Ibd3577defcd53e6d323486071cb7ea6250b89274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205994 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/main@{#928291}
https://screenshot.googleplex.com/ACZ29DGttbL9kiF Bug: 1221297 Change-Id: I10a66ed6d2f6479ac32266c6c0a699d317cfd09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3198945 Commit-Queue: Matt Walliser <mattwalliser@google.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#928292}
This CL updates the ash version 96.0.4661.0 for Lacros version skew testing. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC svenzheng@chromium.org, liaoyuke@chromium.org, yjt@google.com. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: I43bbc80d2e76aa088ae9f32951b89c5b10897b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3206550 Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#928293}
- Use libyuv CopyPlane instead of rolling our own in two places - Change DLOG(ERROR) to DVLOG(1) for a potentially spammy log - Retrieve D3D11 device from texture instead of ANGLE EGLDevice - Gate MapOnDefaultTextures behind UnifiedMemoryArchitecture Bug: 1247414 Change-Id: I19d2a4aaf1c7e5aa898e5904b1432501051ac9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3199115 Reviewed-by: Rafael Cintron <rafael.cintron@microsoft.com> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/main@{#928294}
Resolves a bunch of TODOs created a couple years ago when I was working on getting an UnknownPtr<> util into /base/memory/. That was mostly abandoned in favor of the still-experimental base::raw_ptr<>, but now there's base::SafeRef<> that is essentially the same as the old UnknownPtr<> plan. Change-Id: I041f2515882e3d385816c03140a16065a66b2b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3192792 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/main@{#928295}
- Moved related Mojo types to a separate .mojom file and removed the Nearby prefixes to make them agnostic to the connection medium type. This makes it easier to add the RegisterPayloadFile API to the Secure Channel client API (see discussion in https://crrev.com/c/3189190) - Replaced the |file_path| param with a pair of file descriptors to avoid passing potentially unvalidated paths through multiple IPC layers. This now matches the Nearby Connections' API definition. Bug: 1221297 Change-Id: I546016643187744a9a24e4f9302a6a3347570c49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205614 Reviewed-by: Alex Gough <ajgo@chromium.org> Reviewed-by: Josh Nohle <nohle@chromium.org> Commit-Queue: Jason Sun <jasonsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#928296}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )