Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move icons to left #270

Merged
merged 2 commits into from
Oct 19, 2017
Merged

Move icons to left #270

merged 2 commits into from
Oct 19, 2017

Conversation

Conor0Callaghan
Copy link
Contributor

Move icons to the left as per #203 and re-check OS/free/paid software, update icons accordingly.

  • Moved icons using regex find/replace in vim
  • Changed some URLs to site pages rather than referrals
  • Manually changed paid/non OS software icons

@luong-komorebi
Copy link
Owner

@ivernus Hi there. Thank you for your hard work. I really appreciate it.
However, there is one problem that I just noticed. Our project has the open source icon linked to the app source page, but now with your moving icon, that kind of link vanished, too. If you are doing all of this via a script, we should modify it a little bit to keep the link that follow the open source icon.
Does that sound OK to you?

@Conor0Callaghan
Copy link
Contributor Author

Thanks for reviewing @LewisVo , yep I see those links on the original, I will try to figure out a way of getting them back in.

@luong-komorebi
Copy link
Owner

@ivernus Thank you so much. Your effort is invaluable. Take your time, and also keep your local updated with upstream since big changes are on the way.

@Conor0Callaghan
Copy link
Contributor Author

No worries thanks @LewisVo
Notes on the changes, vim find replace was: 94,941s/(^-)(.)([![.)/- \3\2/ , plus some manual changes also 😞

@luong-komorebi
Copy link
Owner

After a thorough review, I can notice some minor problems, like the nonfree icon is still wrapped by brackets. But it's okay. I will continue working on this, you can take a rest now. Thank you

@luong-komorebi
Copy link
Owner

Done, thanks again @ivernus

@luong-komorebi luong-komorebi merged commit 14f5cdc into luong-komorebi:master Oct 19, 2017
@luong-komorebi
Copy link
Owner

Hi @ivernus , can you make your script or any method that you use to move the icon to the left work with other translation like Spanish

@Conor0Callaghan
Copy link
Contributor Author

Ill take a look to see how easy it is @LewisVo

@Conor0Callaghan
Copy link
Contributor Author

Maybe on this one you could do with some sort of i18n documents that could automatically generate the lists to the right format based on some translations? e.g. https://github.com/gisce/markdown-i18n

@luong-komorebi
Copy link
Owner

That would take some times since I am not familiar with this @ivernus 😄 . Will try do it in my freetime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants