SuperNova: Fix ROM test and remove dead code #127

adr1anh · 2023-11-16T19:03:52Z

The ROM test was broken and not actually doing what it was supposed to.
In particular:

The input rom_index was initialized with the first opcode, rather than 0
SquareCircuit::synthesize was checking the next opcode twice
constrain_augmented_circuit_index was not checking what it was supposed to.

This issue was found while trying to remove dead code in PR #120.

porcuquine · 2023-11-17T17:48:07Z

Let's merge #120 then rebase this to simplify review, please.

adr1anh · 2023-11-17T19:47:01Z

Let's merge #120 then rebase this to simplify review, please.

Done, the changes are much smaller now.

porcuquine · 2023-11-20T20:06:09Z

src/supernova/test.rs

+    let circuit_primary = test_rom.primary_circuit(op_code);
+    let circuit_secondary = test_rom.secondary_circuit();


Maybe move these bindings to the top of the loop and use them in the binding of recursive_snark also.

Good catch!

porcuquine

This seems fine. Independent of bug fixes, I agree that simplifying the logic of this test example is useful. I think it exists in its current form for historical reasons, and there is little value in preserving the specific 'ROM' use case beyond the extent to which it also serves as a clear test and example. These changes seem to bring it closer to serving that purpose.

huitseeker · 2023-11-20T21:14:11Z

src/supernova/test.rs

@@ -88,55 +38,58 @@ where
    }
  }
 }
-/// c = a + b where a, b is `AllocatedNum`
-pub fn add_allocated_num<F: PrimeField, CS: ConstraintSystem<F>>(


In case this comes up one day, https://github.com/lurk-lab/bellpepper/blob/main/crates/bellpepper-core/src/gadgets/num.rs#L279-L309

This backports the following Arecibo PRs: - #2 - #3 - #10 - #16 - #23 - #30 - #28 - #41 - #45 - #50 - #56 - #51 - #72 - #92 - #95 - #97 - #101 - #110 - #106 - #112 - #114 - #119 - #120 - #127 - #123 - #131 - #174 - #175 - #182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>

This implements [Supernova](https://eprint.iacr.org/2022/1758), allowing: - a 'pay-as-you-go' cost structure for folding operations, through the SuperNova folding scheme, - a final SNARK that efficiently compresses an instance of this folded proof, through batching techniques. References: - the [blog post](https://blog.lurk-lang.org/posts/arecibo-supernova/#technical-release-note-supernova-protocol-integration-into-nova) goes into our construction, and links to two more specialized notes on [the `CompressedSNARK` for Supernova](https://hackmd.io/@adr1anh/BJw1g0aBT) along with our variant of the [public input padding issue](https://hackmd.io/@adr1anh/Sy08YaVBa). - the Readme at `src/supernova/Readme.md` This backports the following Arecibo PRs: - lurk-lab/arecibo#2 - lurk-lab/arecibo#3 - lurk-lab/arecibo#10 - lurk-lab/arecibo#16 - lurk-lab/arecibo#23 - lurk-lab/arecibo#30 - lurk-lab/arecibo#28 - lurk-lab/arecibo#41 - lurk-lab/arecibo#45 - lurk-lab/arecibo#50 - lurk-lab/arecibo#56 - lurk-lab/arecibo#51 - lurk-lab/arecibo#72 - lurk-lab/arecibo#92 - lurk-lab/arecibo#95 - lurk-lab/arecibo#97 - lurk-lab/arecibo#101 - lurk-lab/arecibo#110 - lurk-lab/arecibo#106 - lurk-lab/arecibo#112 - lurk-lab/arecibo#114 - lurk-lab/arecibo#119 - lurk-lab/arecibo#120 - lurk-lab/arecibo#127 - lurk-lab/arecibo#123 - lurk-lab/arecibo#131 - lurk-lab/arecibo#174 - lurk-lab/arecibo#175 - lurk-lab/arecibo#182 Co-authored-by: WYATT <wyattbenno@gmail.com> Co-authored-by: Hanting Zhang <hantingz@usc.edu> Co-authored-by: Ming <hero78119@gmail.com> Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: Samuel Burnham <45365069+samuelburnham@users.noreply.github.com> Co-authored-by: Matej Penciak <96667244+mpenciak@users.noreply.github.com> Co-authored-by: Adrian Hamelink <adrian.hamelink@gmail.com>

adr1anh marked this pull request as ready for review November 16, 2023 20:35

adr1anh requested a review from porcuquine November 16, 2023 20:35

adr1anh added 2 commits November 17, 2023 20:44

fix rom test and dead code

52dd087

Fix digest

8252720

adr1anh force-pushed the ah/sn_fix_test branch from bc6d529 to 8252720 Compare November 17, 2023 19:45

porcuquine reviewed Nov 20, 2023

View reviewed changes

porcuquine previously approved these changes Nov 20, 2023

View reviewed changes

huitseeker previously approved these changes Nov 20, 2023

View reviewed changes

Move circuit to top of loop

fbebbec

adr1anh dismissed stale reviews from huitseeker and porcuquine via fbebbec November 21, 2023 11:44

adr1anh enabled auto-merge November 21, 2023 11:45

huitseeker approved these changes Nov 21, 2023

View reviewed changes

adr1anh added this pull request to the merge queue Nov 21, 2023

Merged via the queue into lurk-lab:dev with commit 753fe39 Nov 21, 2023
3 checks passed

adr1anh deleted the ah/sn_fix_test branch November 21, 2023 16:46

huitseeker added the supernova label Nov 29, 2023

huitseeker mentioned this pull request Dec 18, 2023

feat: implement SuperNova microsoft/Nova#283

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SuperNova: Fix ROM test and remove dead code #127

SuperNova: Fix ROM test and remove dead code #127

adr1anh commented Nov 16, 2023

porcuquine commented Nov 17, 2023

adr1anh commented Nov 17, 2023

porcuquine Nov 20, 2023

adr1anh Nov 21, 2023

porcuquine left a comment

huitseeker Nov 20, 2023

		let circuit_primary = test_rom.primary_circuit(op_code);
		let circuit_secondary = test_rom.secondary_circuit();

SuperNova: Fix ROM test and remove dead code #127

SuperNova: Fix ROM test and remove dead code #127

Conversation

adr1anh commented Nov 16, 2023

porcuquine commented Nov 17, 2023

adr1anh commented Nov 17, 2023

porcuquine Nov 20, 2023

Choose a reason for hiding this comment

adr1anh Nov 21, 2023

Choose a reason for hiding this comment

porcuquine left a comment

Choose a reason for hiding this comment

huitseeker Nov 20, 2023

Choose a reason for hiding this comment