Skip to content

Commit

Permalink
Retire more proving from Lurk Alpha (#875)
Browse files Browse the repository at this point in the history
* refactor: Refactor codebase by removing MultiFrame struct usage

- Removed the entire `MultiFrame` struct execution across multiple files.
- Altered import statements to match the changes in the codebase.

* refactor: Remove dead code

- Removed the method `chunk_size` from the `Flow` enum in `config.rs`.
- Eliminated several imports in `circuit_frame.rs`, including `ConsCircuitWitness`, `ContCircuitWitness`, `HashCircuitWitnessCache`, `Frame` from `eval`, and `HashWitness`.
- Removed the function `from_frame` from `CircuitFrame` implementation and significantly pared down the `synthesize` function within the same implementation.
- Introduced `#[allow(dead_code)]` annotations on `reduce_expression` and `apply_continuation` functions, marking them as currently unused but potentially useful in the next few commits

* refactor: Refactor dead code

- Eliminated redundant code and unused imports across multiple files,
- Removed obsolete methods, such as `num_threads` from config module, `new` and `new_dummy` from `Slot` struct, and `from_cons_witness` and `from_cont_witness`.

* refactor: Refactor `CircuitHashWitness` and remove `HashConst`

- Eliminated the `HashConst` struct from the `hash_witness.rs` source file.
- Removed the unused `circuit_witness_blocks` and `names_and_ptrs` methods for the `CircuitHashWitness`.
  • Loading branch information
huitseeker committed Nov 9, 2023
1 parent c6dc3cc commit 80ea3a1
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 803 deletions.
Loading

1 comment on commit 80ea3a1

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmarks

Table of Contents

Overview

This benchmark report shows the Fibonacci GPU benchmark.
NVIDIA GeForce RTX 4070
AMD Ryzen 9 3950X 16-Core Processor
125.711 GB RAM

Benchmark Results

LEM Fibonacci Prove - rc = 100

fib-ref=c6dc3ccb9b24346a20da33a401d2542f05bb1653 fib-ref=80ea3a1058f8f0883669bcca0c61372cb423b209
num-100 3.96 s (✅ 1.00x) 3.98 s (✅ 1.00x slower)
num-200 8.77 s (✅ 1.00x) 8.93 s (✅ 1.02x slower)

LEM Fibonacci Prove - rc = 600

fib-ref=c6dc3ccb9b24346a20da33a401d2542f05bb1653 fib-ref=80ea3a1058f8f0883669bcca0c61372cb423b209
num-100 3.05 s (✅ 1.00x) 3.05 s (✅ 1.00x faster)
num-200 7.02 s (✅ 1.00x) 7.05 s (✅ 1.00x slower)

Made with criterion-table

Please sign in to comment.