Retire more proving from Lurk Alpha #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the entire `MultiFrame` struct execution across multiple files. - Altered import statements to match the changes in the codebase.
- Removed the method `chunk_size` from the `Flow` enum in `config.rs`. - Eliminated several imports in `circuit_frame.rs`, including `ConsCircuitWitness`, `ContCircuitWitness`, `HashCircuitWitnessCache`, `Frame` from `eval`, and `HashWitness`. - Removed the function `from_frame` from `CircuitFrame` implementation and significantly pared down the `synthesize` function within the same implementation. - Introduced `#[allow(dead_code)]` annotations on `reduce_expression` and `apply_continuation` functions, marking them as currently unused but potentially useful in the next few commits
- Eliminated redundant code and unused imports across multiple files, - Removed obsolete methods, such as `num_threads` from config module, `new` and `new_dummy` from `Slot` struct, and `from_cons_witness` and `from_cont_witness`.
- Eliminated the `HashConst` struct from the `hash_witness.rs` source file. - Removed the unused `circuit_witness_blocks` and `names_and_ptrs` methods for the `CircuitHashWitness`.
huitseeker
force-pushed
the
retire_more_proving
branch
from
c5aa086
to
f18bc27
Compare
arthurpaulino
approved these changes
Nov 9, 2023
Comment on lines
-57
to
-68
| #[derive(Debug, Clone)] | ||
| pub struct MultiFrame<'a, F: LurkField, C: Coprocessor<F>> { | ||
| pub store: Option<&'a Store<F>>, | ||
| pub input: Option<IO<F>>, | ||
| pub output: Option<IO<F>>, | ||
| pub frames: Option<Vec<CircuitFrame<'a, F, C>>>, | ||
| pub cached_witness: Option<WitnessCS<F>>, | ||
| pub count: usize, | ||
| pub folding_config: Arc<FoldingConfig<F, C>>, | ||
| pub meta: Meta<F>, | ||
| pub next_pc: Option<usize>, | ||
| } |
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This retires Lurk-Alpha only proving facilities up to #874, which focuses on gadgets. As we get to that last issue, we'll need to move these gadgets to
bellpepper-gadgetsorbellpepper