Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUR-21] Remove the MultiFrameTrait trait #1015

Closed
huitseeker opened this issue Jan 3, 2024 · 0 comments · Fixed by #1026
Closed

[LUR-21] Remove the MultiFrameTrait trait #1015

huitseeker opened this issue Jan 3, 2024 · 0 comments · Fixed by #1026
Assignees

Comments

@huitseeker
Copy link
Member

huitseeker commented Jan 3, 2024

In the past, in #642, #644, #709, we introduced a MultiFrameTrait that abstracted over the differences in creating evaluation frames, and deducing a nova StepCircuit from them as a way to abstract over the differences in proving between Lurk Alpha and LEM.

We have adopted LEM and retired the Lurk alpha implementation in #873 #875.

So we only have one implementation of this trait today:

huitseeker@lightning.local»lurk-rs(main✗)» rg 'impl.*?MultiFrameTrait.*?for '
src/lem/multiframe.rs
387:impl<'a, F: LurkField, C: Coprocessor<F> + 'a> MultiFrameTrait<'a, F, C> for MultiFrame<'a, F, C> {

This trait should be removed, its implementation inlined in an impl block, and its only instance inlined for the structs that have an M: MultiFrameTrait<'a, F, C> as a generic parameter.

LUR-21

@huitseeker huitseeker changed the title Remove the MultiFrameTrait trait [LUR-21] Remove the MultiFrameTrait trait Jan 3, 2024
@huitseeker huitseeker self-assigned this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant