Multiframe trait wip #644
Merged
Multiframe trait wip #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce in MultiFrame implementations (#643)
huitseeker
approved these changes
Aug 30, 2023
porcuquine
added a commit
that referenced
this pull request
Aug 30, 2023
* Implement MultiFrameTrait. * Move more methods to MultiFrameTrait. * Use associated type. * Make AllocatedIO an associated type. * Multiframe trait wip (#644) * --wip-- * refactor: Refactor proof and public parameters to account for difference in MultiFrame implementations (#643) * Arc the Func. --------- Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com> * Clippy --------- Co-authored-by: porcuquine <porcuquine@users.noreply.github.com> Co-authored-by: François Garillot <4142+huitseeker@users.noreply.github.com>
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although this has one compile error still, it gets most of the way to implementing
MultiFrameTraitforlem::circuit::MultiFrame. Thanks to @huitseeker for the public-parameter work.