Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add action to open cargo-release PR #202

Merged
merged 4 commits into from
Jul 3, 2023

Conversation

samuelburnham
Copy link
Member

No description provided.

Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing pieces:

Nice to have:

  • it would be nice to do a minimum of checks on the version argument, if only to avoid typos.
    This snippet, which retrieves the current version, might help:
cargo metadata --format-version 1 | \
    jq --arg crate_name "neptune" --exit-status -r \
        '.packages[] | select(.name == neptune) | .version'

or I would also be happy with some semver check / regexp

@huitseeker
Copy link
Member

For inspiration: privacy-scaling-explorations/halo2curves#59

Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSVM!!

@huitseeker huitseeker added this pull request to the merge queue Jul 3, 2023
Merged via the queue into lurk-lab:main with commit a3e9a96 Jul 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants