CHEF-2916: Disable GC in popen4 to avoid mythical Ruby 1.8 IO.select bug

lusis · Feb 9, 2012 · 64f5dd0 · 64f5dd0
1 parent e7360a2
commit 64f5dd0
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/chef/lib/chef/mixin/command/unix.rb b/chef/lib/chef/mixin/command/unix.rb
@@ -28,6 +28,9 @@ module Unix
         #
         # Thanks Ara!
         def popen4(cmd, args={}, &b)
+          # Ruby 1.8 suffers from intermittent segfaults believed to be due to GC while IO.select
+          # See CHEF-2916 / CHEF-1305
+          GC.disable
 
           # Waitlast - this is magic.
           #
@@ -207,6 +210,8 @@ def popen4(cmd, args={}, &b)
           else
             [cid, pw.last, pr.first, pe.first]
           end
+        ensure
+          GC.enable
         end
 
       end