Better handling of default Wine version

[rkben]

Setting the Wine Version under the Wine runner is not respected when installing an executable.

Eg. runners/wine.yml

system:
  disable_compositor: false
wine:
  battleye: false
  eac: false
  esync: false
  fsr: false
  fsync: false
  version: lutris-GE-Proton7-15-x86_64

Will set any new prefix with Lutris' default (lutris-fshack) wine version instead of lutris-GE-ProtonX-xx.

• Lutris Version: 0.5.10.1

[strycore]

There are several things we need to fix:

• Lutris defaults to whichever Wine version is the highest, this is not always desirable (ex: LoL build having a higher version than the normal build)
• The install process fetches the default Wine version for Lutris (as set by the dev team) but this default version isn't enforced anywhere else
• The wine version used during install can't easily be overridden.

[danieljohnson2]

Is this reproducable still? I thought all this was working by 0.5.13.

It's not exactly the same as #4370, but the code for this looks solid to me.

[strycore]

We haven't fixed what I mentioned in my comment.

[TormStorm]

Any updates on this issue?

[danieljohnson2]

The runner's default Wine version is now respected when installing (unless the script specifies a version); I needed that myself quite recently, and it worked.

The next Lutris release should download the latest Wine when installing a game, so that the default Wine for the new install can update (if not otherwise set) at that time. It's not "enforced" anywhere else, I guess, but I don't know what @strycore intends by that.

You can override the Wine version used for installs by configuring the runner, but maybe that is not "easily" enough.

You cannot override a script though - in Soviet Lutris, the script overrides you!

I have no plans for further work in this area, at least until I understand what @strycore wants to do here,

[strycore]

I've made some further changes yesterday.
Lutris now gets all runtime and runner versions from a single API request. This request is saved to ~/.cache/lutris/versions.json

New Wine versions will be downloaded when Lutris starts. Not when installing a game, not when starting a game.

We still need a widget to override the wine version used during installs but that's less urgent. We don't want people fiddling with that too much, game installs should work with our recommended build, otherwise they should report it as a bug. Or pin the wine version in the installer if the bug is already reported and awaiting a fix.

[strycore]

I realized that I made this comment while I had a bunch of related changes still sitting on my computer. This commit should make things clearer: 58dfa87

[strycore]

Once I download the default wine on startup, I'll close the ticket. Adding the dropdown to select wine versions during installs is out of scope for this particular feature.

[nmlynch94]

Just to clarify, does this fix address the problem you mentioned earlier in the thread where sometimes the installer would default to something like a LoL build instead of the latest wine-ge version? That's something we ran into in the past and have been pinning the build to the latest wine-ge instead.

[strycore]

yes, it does fix it since it will be much harder to not have the recommended wine version.

[strycore]

Lutris now downloads the recommended Wine version on startup. This can be closed.