Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installs with "requires" replace previous game settings #72

Closed
Letiliel opened this issue Jul 17, 2014 · 4 comments
Closed

Installs with "requires" replace previous game settings #72

Letiliel opened this issue Jul 17, 2014 · 4 comments
Labels
Milestone

Comments

@Letiliel
Copy link
Contributor

Installing a mod/patch/wathever on top of a game will erase previous game-level configuration. It should keep existing config and only replace settings that are set in the script.

@Letiliel Letiliel added the bug label Jul 17, 2014
@strycore strycore added this to the 0.3.5 milestone Aug 14, 2014
@strycore
Copy link
Member

strycore commented Sep 3, 2014

Ok, so the thing is that 'requires' was not meant to be used this way. It was originally made for one game to depend on another (example, you need Quake 2 to install Quake 2: the Reckoning). The installation process resulted in 2 distinct config files.

I'm going to try and handle this use case, but as an experiment (will still be in 0.3.5 but we may rework this whole thing for 0.3.6)

@strycore
Copy link
Member

strycore commented Sep 3, 2014

This should be fixed, and btw it's now possible to call task from different runners than the original one (for example "wine.set_regedit").

@strycore strycore closed this as completed Sep 3, 2014
@Letiliel
Copy link
Contributor Author

Letiliel commented Sep 4, 2014

Ok, very cool !

I have opinions on how we could handle the patches and mods, so I'll willing to discuss this later on.

@strycore
Copy link
Member

strycore commented Sep 4, 2014

Yes, we need to. The current state of things where you install patches like widescreen support for flatout 2 like you install any other game feels a bit akward to me. We can do better than that.

@lutris lutris locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants