Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support homebrew with lit update command #115

Open
creationix opened this issue Aug 6, 2015 · 1 comment
Open

Support homebrew with lit update command #115

creationix opened this issue Aug 6, 2015 · 1 comment

Comments

@creationix
Copy link
Member

Currently the homebrew style install (using symlinks) from bin to internal files breaks lit's updater. It will think the lit internal folder is the main bin and install a copy of luvit and luvi there where they are not in the user's path. The public luvit and luvi symlinks will still be linked to the old versions and it will look like the update failed.

We could be clever and read the symlinks and update the target binaries in-place. Also we could replace the symlinks with normal bianries. Both of these methods break assumptions that homebrew makes. We could just refuse to update in this case and tell them to update via homebrew (hoping they can keep up with our rapid release schedule)

@creationix
Copy link
Member Author

Yes, the solution will be to detect a homebrew install and disable update in that case. We'll print a nice message to the user that they need to update via the homebrew system instead since that is how they initially installed luvit and lit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant