Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider upgrading the minimum required version of cmake #616

Closed
dundargoc opened this issue Sep 21, 2022 · 1 comment · Fixed by #617
Closed

Please consider upgrading the minimum required version of cmake #616

dundargoc opened this issue Sep 21, 2022 · 1 comment · Fixed by #617

Comments

@dundargoc
Copy link
Contributor

dundargoc commented Sep 21, 2022 •
edited

Compatibility with CMake < 2.8.12 will be removed from a future version of CMake. I'd like to make a request that we move the minimum required version to at least 3.0 to ensure we don't rely on deprecated features. This will also get rid of the annoying deprecation warning each time the project is built.

Please feel free to close the issue if this isn't possible or wanted.
@squeek502
Copy link
Member

Unless there's reason not to, seems like the 'safest' thing to do would just be to set the minimum to 2.8.12.

squeek502 added a commit to squeek502/luv that referenced this issue Sep 21, 2022
@squeek502
cmake: Bump minimum version to 2.8.12
f070582 
Removes the following deprecation warning:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Closes luvit#616
@squeek502 squeek502 mentioned this issue Sep 21, 2022
Merged
squeek502 added a commit that referenced this issue Sep 22, 2022
@squeek502
cmake: Bump minimum version to 2.8.12 (#617)
80c8c00 
Removes the following deprecation warning:

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

Closes #616
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmake: Bump minimum version to 2.8.12 squeek502/luv
2 participants
@squeek502 @dundargoc