You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Branch: uv-update-1.0.0. MSVC doesn't support some C99 and GNU C features, so attribute((unused)) caused lots of warnings and some errors.
process.c:
int fd; // should the type of this be replaced with uv_os_fd_t? MSVC reports this.
uv_stream_t* stream = luv_check_stream(L, -1);
int err = uv_fileno((uv_handle_t*)stream, &fd);
And util.c:
static void luv_resume_with_status(lua_State* L, int status, int nargs) {
...
return luv_resume(L, 1 + nargs); // this is a void function but it has a return statement
}
And I wonder there is no co-routine design in libuv. Why it called Lua co-routine APIs? If we implement the co-routine support in C code, it won't be a BARE binding. I think co-routine wrapping should be done in Lua.
The text was updated successfully, but these errors were encountered:
Ok, I changed my linter so I don't need those GCC markers. If there are any left I didn't remove, it's a bug. I'm sure I'll find them as I move to building on windows.
Branch: uv-update-1.0.0. MSVC doesn't support some C99 and GNU C features, so attribute((unused)) caused lots of warnings and some errors.
process.c:
And util.c:
And I wonder there is no co-routine design in libuv. Why it called Lua co-routine APIs? If we implement the co-routine support in C code, it won't be a BARE binding. I think co-routine wrapping should be done in Lua.
The text was updated successfully, but these errors were encountered: