Modify the FS_CALL macros to fix MINGW64 builds #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MINGW64 defines stat and fstat to _stat64 and _fstat64 respectively, which is applied globally. This breaks the FS_CALL macros by replacing uv_fs_stat with uv_fs__stat64 and uv_fs_fstat with uv_fs__fstat64 (those obviously don't exist). Fixes luvit#624
Duckwhale
force-pushed
the
mingw64-defines-fix
branch
from
3af531f
to
f70db4d
Compare
squeek502
approved these changes
Nov 22, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINGW64 defines stat and fstat to _stat64 and _fstat64 respectively, which is applied globally. This breaks the FS_CALL macros by replacing uv_fs_stat with uv_fs__stat64 and uv_fs_fstat with uv_fs__fstat64 (those obviously don't exist).
Fixes #624