fix segfault in luv_check_handle/luv_check_stream #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeek502
reviewed
Mar 2, 2023
squeek502
reviewed
Mar 2, 2023
Bilal2453
force-pushed
the
fix-check-segfault
branch
from
0ca43ac
to
9e205e1
Compare
squeek502
approved these changes
Mar 3, 2023
|
Thanks! (looks like the CI is freaking out [Github actions down maybe?], but that's unrelated to this change) |
|
No worries, thank you for helping me out with this, still learning my way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #633.
Is the style I used here OK? It felt kind of different than the rest of the code, the assignments in the if statements more specifically..