Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update uv.tty_set_mode, and add tty test #661

Merged
merged 1 commit into from Aug 14, 2023
Merged

chore: update uv.tty_set_mode, and add tty test #661

merged 1 commit into from Aug 14, 2023

Conversation

zhaozg
Copy link
Member

@zhaozg zhaozg commented Aug 13, 2023

@zhaozg zhaozg force-pushed the master branch 4 times, most recently from 7c7dfc5 to ad725c2 Compare August 13, 2023 15:59
@Bilal2453
Copy link
Contributor

Bilal2453 commented Aug 13, 2023 •
edited

The error message in https://github.com/luvit/luv/pull/661/files#diff-bc73b80291779f6c896ddcb3e37b2ed8567475c138048c14f5318e9771340fa3R53 probably needs a bit of rewording.

  • Value out of acceptable range.
  • Out of range.
  • Unknown mode value. (I prefer this)

@Bilal2453 Bilal2453 mentioned this pull request Aug 13, 2023
Open
@zhaozg zhaozg merged commit eac5451 into luvit:master Aug 14, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeek502 squeek502 squeek502 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhaozg @Bilal2453 @squeek502