Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make uv.kill's signum optional #668

Merged
merged 1 commit into from Aug 22, 2023

Conversation

Bilal2453
Copy link
Contributor

@Bilal2453 Bilal2453 commented Aug 22, 2023

same as #666 for the same reasons.

See

luv/src/process.c

Lines 319 to 324 in 9e3c232

static int luv_kill(lua_State* L) {
int pid = luaL_checkinteger(L, 1);
int signum = luv_parse_signal(L, 2);
int ret = uv_kill(pid, signum);
return luv_result(L, ret);
}

@squeek502
Copy link
Member

CI failure is unrelated: #669

@squeek502 squeek502 merged commit 317b150 into luvit:master Aug 22, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants