Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass -fno-sanitize-recover=all to make all UBSan detections fatal #698

Merged
merged 3 commits into from
Mar 2, 2024
Merged

Pass -fno-sanitize-recover=all to make all UBSan detections fatal #698

merged 3 commits into from
Mar 2, 2024

Commits on Mar 1, 2024

  1. Pass -fno-sanitize-recover=all to make all UBSan detections fatal 

    From the clang docs:

> By default, non-fatal checks are those enabled by UndefinedBehaviorSanitizer, except for -fsanitize=return and -fsanitize=unreachable.
    @squeek502
    squeek502 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dfc1475 View commit details
    Browse the repository at this point in the history

  2. Fix undefined behavior in thread.c 

    This was doing pointer addition where i could be >= LUV_THREAD_MAXNUM_ARG and then subtracting afterwards. By doing the subtraction first, the number is properly bounded within 0..LUV_THREAD_MAXNUM_ARG
    @squeek502
    squeek502 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    eb89959 View commit details
    Browse the repository at this point in the history

  3. Fix undefined behavior in tcp.c

    @squeek502
    squeek502 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    4d56378 View commit details
    Browse the repository at this point in the history