Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce miniz submodule #288

Merged
merged 1 commit into from
Jul 10, 2024
Merged

introduce miniz submodule #288

merged 1 commit into from
Jul 10, 2024

Conversation

zhaozg
Copy link
Member

@zhaozg zhaozg commented Jul 9, 2024

No description provided.

@zhaozg zhaozg marked this pull request as draft July 9, 2024 04:34
@zhaozg
Copy link
Member Author

zhaozg commented Jul 9, 2024

If richgel999/miniz#315 be accept, we can change miniz repo to https://github.com/richgel999/miniz

@zhaozg zhaozg marked this pull request as ready for review July 9, 2024 08:28
@SinisterRectus SinisterRectus mentioned this pull request Jul 9, 2024
@zhaozg
Copy link
Member Author

zhaozg commented Jul 10, 2024

richgel999/miniz#315 has been merged, miniz repo back to https://github.com/richgel999/miniz

@@ -132,8 +132,16 @@ if (WITH_LUA_ENGINE STREQUAL Lua)
endif ()

include(LuaAddExecutable)

# TODO: define MINIZ_NO_STDIO for small size
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this important to do before merging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I hope to make PR to miniz to support MINIZ_NO_STDIO build with cmake later, miniz cmake without MINIZ_NO_STDIO options now. So let's merge, and fix this TODO after miniz with this feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The miniz PR is richgel999/miniz#316

@zhaozg zhaozg merged commit 262d5f7 into luvit:master Jul 10, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants