Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string lua 5.3 compat apis, pack,unpack,packsize #76

Merged
merged 3 commits into from
Apr 14, 2015

Conversation

zhaozg
Copy link
Member

@zhaozg zhaozg commented Mar 29, 2015

No description provided.

@creationix
Copy link
Member

I think this is missing a file. Is there a reason this needs to be in core and not as an addon?

@zhaozg
Copy link
Member Author

zhaozg commented Apr 14, 2015

pack,unpack,packsize are lua 5.3 office api, It's useful to handle structure data and communication protocol, I think luvi should enhance this abilities from core layer.
But these apis not support by luajit, and because this need include other projects, so please keep this RP open, maybe I can find better solutions.

@zhaozg
Copy link
Member Author

zhaozg commented Apr 14, 2015

@imzyxwvu
Copy link

I agree with it that this would help a lot working with binary data and binary protocol streams and should be included in luvi as an extension to the Lua standard library. You could port the implement of Lua 5.3. I have also an fifo in-memory stream implement which works better than decoders with binary protocol streams and planning to open an PR.

在 2015年4月14日,09:07,George Zhao notifications@github.com 写道:

pack,unpack,packsize are lua 5.3 office api, It's useful to handle structure data and communication protocol, I think luvi should enhance this abilities from core layer.
But these apis not support by luajit, and because this need include other projects, so please keep this RP open, maybe I can find better solutions.


Reply to this email directly or view it on GitHub.

@creationix
Copy link
Member

+1

rphillips added a commit that referenced this pull request Apr 14, 2015
Add string lua 5.3 compat apis, pack,unpack,packsize
@rphillips rphillips merged commit 7a42a9d into luvit:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants