Add info about a timer bug fix. #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe too verbose? Could this be shortened while still being descriptive? |
|
@creationix Sure. Is 1a286b6 better? I also referenced the pull request number in the message. I plan to open another PR which adds ticket references to other messages unless you don't like this idea. |
|
@Kami Can you make it one line. People can reference the ticket if they want more details. |
|
@Kami Thanks for adding this. Sorry I missed it, I obviously had a lot of stuff to sort through. 6 months of work! |
philips
added a commit
that referenced
this pull request
Dec 20, 2012
Add info about a timer bug fix.
|
@philips No problem and thanks! |
zhaozg
pushed a commit
to zhaozg/luvit
that referenced
this pull request
Apr 2, 2019
Add info about a timer bug fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a missing changelog entry :)