-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for all dtypes, adds more tests and fixes small bugs #102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
+ Coverage 74.94% 75.00% +0.05%
==========================================
Files 36 36
Lines 2415 2412 -3
==========================================
- Hits 1810 1809 -1
+ Misses 605 603 -2
Continue to review full report at Codecov.
|
This looks great! One remaining issue in #79 is the use of |
This commit checks if dtype of a column is of type In addition, metadata is also expired in |
This looks great, thanks @westernguy2 ! |
This pull request solves the issue in #79 where the dtype of a column is not being assigned a data_type in
data_type_lookup
, resulting in an error. This is resolved by setting any column that has a dtype not being accounted for asnominal
. In addition, it became clear that theordinal
data type wasn't being used, so that was removed from Lux.Also fixed are bugs relating to
__getattr__
due to a missing return value, which fixed the issue where accessing columns of a DataFrame via dot notation wasn't working.Finally, some more tests for
.loc
and.iloc
were added, as well as a new test forgroupby.agg
which hasn't been resolved yet (in issue #66 ).