Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit data type override via df.set_data_type #215

Merged
merged 25 commits into from
Jan 18, 2021
Merged

Explicit data type override via df.set_data_type #215

merged 25 commits into from
Jan 18, 2021

Conversation

jinimukh
Copy link
Member

@jinimukh jinimukh commented Jan 11, 2021 •
edited by dorisjlee
Loading

This PR addresses #99 and implements the option for the user to specify lux type in case our inferred type is incorrect.

Changed:

  • implementation for df.set_data_type: includes a call to df.maintain_metadata() if relevant metadata does not yet exist.
  • tests for correctness and failure cases
  • update warning thrown when Lux detects temporal warnings to also include set_data_type suggestion.

thyneb19
thyneb19 reviewed Jan 12, 2021
View reviewed changes
lux/core/frame.py Outdated Show resolved Hide resolved
@jinimukh jinimukh changed the title df.asLuxType({}) implementation df.set_data_type({}) implementation Jan 14, 2021
@dorisjlee dorisjlee changed the title df.set_data_type({}) implementation Supporting explicit data type override via df.set_data_type Jan 14, 2021
@dorisjlee dorisjlee changed the title Supporting explicit data type override via df.set_data_type Explicit data type override via df.set_data_type Jan 14, 2021
@dorisjlee
Copy link
Member

Thanks @jinimukh, this looks great! I've tested the code and made minor changes to the docs and warnings.
Once we add some documentation around this feature, we should be able to merge in the changes.

@dorisjlee dorisjlee merged commit dd43cc9 into lux-org:master Jan 18, 2021
@dorisjlee
Copy link
Member

Thanks @jinimukh !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorisjlee dorisjlee dorisjlee approved these changes

@thyneb19 thyneb19 thyneb19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinimukh @dorisjlee @thyneb19