Expand LuxGroupby Tests and add bug fixes #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyneb19
reviewed
Feb 25, 2021
|
|
||
| def test_name_column(global_var): | ||
| df = pd.read_csv("lux/data/car.csv") | ||
| new_df = df.rename(columns={"Name": "name"}) |
There was a problem hiding this comment.
for this test, can we do a quick check that the values of the "name" column have not all been converted to None values?
There was a problem hiding this comment.
Thanks! I added a few more assert statements to check for this case!
thyneb19
approved these changes
Feb 28, 2021
dorisjlee
approved these changes
Mar 2, 2021
|
These changes looks great, thanks @westernguy2 ! (and thanks to @thyneb19 for helping with the review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request expands the tests for LuxGroupby to test if a LuxDataFrame is pre_aggregated after a groupby. It also patches the edge case of LuxDataFrame having a "name" column among other bug fixes.
Changes
This pull request is mainly for adding tests to LuxGroupby that didn't check if a LuxDataFrame is pre_aggregated after a groupby in certain cases.
In addition, this PR adds the "name" column back to the metadata, which patches the bug described in the above Overview. A test has been added to ensure this doesn't change.
Finally, this PR also patches small bugs relating to groupby and LuxGroupby. For instance, it adds
applyas one of the methods extended from Pandas Groupby. It also fixes an edge case where the name of a Series was being changed. This is patched by directly editing unnamed columns (named by default as 0) to a blank string.Example Output
The expected behavior should model the expected behavior of Pandas for the different patches described above.