Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve empty vis bug for geographic data types #318

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

micahtyong
Copy link
Member

Overview

Previously, choropleth visualizations would not appear when x_attr or y_attr was abbreviated. With this change, all choropleth visualizations should appear as expected.

Changes

  • Modifications in vislib/altair/Choropleth.py

Example Output

Now, when we run

import pandas as pd
import lux
df = pd.read_csv("https://raw.githubusercontent.com/lux-org/lux-datasets/master/data/hpi.csv")
df

we should get the following output with no empty visualizations.
Screen Shot 2021-03-22 at 3 26 52 PM

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #318 (c04b3a8) into master (f45d051) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head c04b3a8 differs from pull request most recent head 7484b91. Consider uploading reports for the commit 7484b91 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   80.98%   80.87%   -0.12%     
==========================================
  Files          50       50              
  Lines        3618     3618              
==========================================
- Hits         2930     2926       -4     
- Misses        688      692       +4     
Impacted Files Coverage Δ
lux/vislib/altair/Choropleth.py 94.20% <ø> (ø)
lux/vislib/altair/Heatmap.py 93.10% <0.00%> (-3.45%) ⬇️
lux/vislib/altair/ScatterChart.py 93.93% <0.00%> (-3.04%) ⬇️
lux/vislib/matplotlib/Heatmap.py 96.66% <0.00%> (-1.67%) ⬇️
lux/vislib/matplotlib/ScatterChart.py 75.29% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45d051...7484b91. Read the comment docs.

@dorisjlee dorisjlee merged commit 2553125 into lux-org:master Mar 23, 2021
@dorisjlee
Copy link
Member

This looks great, thanks @micahtyong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants