Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera: move alpha parameter as optional to be consistent with stereo #867

Merged
merged 3 commits into from
Jul 5, 2023
Merged

Camera: move alpha parameter as optional to be consistent with stereo #867

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ef1175
Camera: move alpha parameter as optional to be consistent with stereo
SzabolcsGergely Jul 4, 2023
b4fe512
Merge remote-tracking branch 'origin/develop' into camera_node_alpha_…
SzabolcsGergely Jul 4, 2023
4faa36e
Update FW
SzabolcsGergely Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/Depthai/DepthaiDeviceSideConfig.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
set(DEPTHAI_DEVICE_SIDE_MATURITY "snapshot")

# "full commit hash of device side binary"
set(DEPTHAI_DEVICE_SIDE_COMMIT "6ff42a5c5a99cde04f015f6694d5e611f7dc2939")
set(DEPTHAI_DEVICE_SIDE_COMMIT "91fd63cb4e50b716bbd22e667d86fcc904bee92c")

# "version if applicable"
set(DEPTHAI_DEVICE_SIDE_VERSION "")
2 changes: 1 addition & 1 deletion include/depthai/pipeline/node/Camera.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ class Camera : public NodeCRTP<Node, Camera, CameraProperties> {
/// Set calibration alpha parameter that determines FOV of undistorted frames
void setCalibrationAlpha(float alpha);
/// Get calibration alpha parameter that determines FOV of undistorted frames
float getCalibrationAlpha() const;
tl::optional<float> getCalibrationAlpha() const;

/**
* Configures whether the camera `raw` frames are saved as MIPI-packed to memory.
Expand Down
2 changes: 1 addition & 1 deletion shared/depthai-shared
Open in desktop
Submodule depthai-shared updated 1 files
+8 −1 include/depthai-shared/properties/CameraProperties.hpp
2 changes: 1 addition & 1 deletion src/pipeline/node/Camera.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ void Camera::setCalibrationAlpha(float alpha) {
properties.calibAlpha = alpha;
}

float Camera::getCalibrationAlpha() const {
tl::optional<float> Camera::getCalibrationAlpha() const {
return properties.calibAlpha;
}

Expand Down
Loading