Pmolloy/install deps #115
Merged
Pmolloy/install deps #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little clean-up and reorganization of this script with the intention of using it, (or at least the package lists) for Docker images (or potentially VM images). And then maybe one day even system packages.
I added some support for Fedora, but it could use more work.
I also swapped out the Fedora container with a full VM since I ran into problems where the container is not representative of a full Fedora installation. Note this isn't an issue for Ubuntu because Github provides full Ubuntu virtualized environments.
And updated the workflow to only run when the script is modified since the VM takes a lot longer to run than a container.