Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor update noetic #398

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Sensor update noetic #398

merged 4 commits into from
Sep 11, 2023

Conversation

Serafadam
Copy link
Collaborator

Overview

Author: @Serafadam

Issue

Issue link (if present): #396 #393
Issue description: Update sensor logic regarding board socket names and pipeline validation, add Readme information on available sensor resolutions.
Related PRs

Changes

ROS distro: Noetic
List of changes:

  • Move sensor names, types etc. to sensor_helpers.cpp to keep it in one place
  • Update setting board socked ID's as parameters to use defaults
  • Fix bug where pipeline type wasn't properly changed for OAK-1

Testing

Hardware used: OAK-1, OAK-D-PRO
Depthai library version: 2.20.0

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.

@Serafadam Serafadam mentioned this pull request Sep 8, 2023
@Serafadam Serafadam merged commit 5dea05c into noetic Sep 11, 2023
3 checks passed
@Serafadam Serafadam deleted the sensor_update_noetic branch September 11, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant