Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-standard devices #1077

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Conversation

Erol444
Copy link
Member

@Erol444 Erol444 commented Jul 6, 2023

A few fixes:

  • When creating color camera, it will take first color sensor, which fixes many issues for eg. OAK-D-SR
  • Auto-downscale stereo frames if they're above 1280pixels in width; fixes issues with OAK-D-LR
  • Select stereoLeft camera when creating left camera, and stereoRight when creating right camera. This could fix some issues with custom devices, or FFC setups, where left/right aren't cam_b/cam_c ports
  • In CameraComponent, added option for resolution='max', whcih will set max supported camera resolution

TODO:

…modules). Take stereo left/right sockets by default. Take first color camera if "color" is passed
…reo frames if they are larger than 1280pixels in width
@Erol444 Erol444 marked this pull request as ready for review July 6, 2023 10:55
Copy link
Contributor

@geektrove geektrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geektrove geektrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about cam_b,c as source?

@geektrove
Copy link
Contributor

I think we should split source (CameraComponent) into two args, one will represent socket, and the second type (color or mono). In the newest version of depthai they also deprecated usage of dai.CameraBoardSocket.COLOR, .RGB, .LEFT, etc. so it makes sense to me. This way user can explicitly say "I want color type, socket doesn't matter". Thoughts?

@Erol444 Erol444 requested a review from geektrove July 12, 2023 16:51
@Erol444
Copy link
Member Author

Erol444 commented Jul 12, 2023

@OpeningNew Added the option to specify mono/color back

@Erol444 Erol444 merged commit b8fed32 into develop Jul 15, 2023
1 check passed
@Erol444 Erol444 deleted the stereo_use_correct_cam_ids branch July 15, 2023 17:35
@Jalen-Xu
Copy link

Jalen-Xu commented Aug 7, 2023

Hi,

I am running oak-d-sr camera with this latest depthai_demo sdk but I am not able to see the depth image successfully as shown below. I can only see the color image and nnInput image.

image

@Erol444
Copy link
Member Author

Erol444 commented Aug 7, 2023

Hi @Jalen-Xu ,
the DepthAI demo doesn't have support for OAK-D-SR, and we are migrating to depthai-viewer - I'd suggest using that one instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants