Fixed website and theme status ActiveButtons (PHP 8) #406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing/introducing
enableValue=1
anddisableValue=0
forToggleStatusActiveButton
inWebsite
andTheme
model.What is the reason for changing/introducing
Rector replaced the
switch
statement inluya-module-admin/src/buttons/ToggleStatusActiveButton::toggleValue()
with new PHP 8match
statement (see luyadev/luya-module-admin@5e0574a).Because of
toggling to other values than
true
orfalse
leads into anInvalidArgumentException
.QA