Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model validation bug #15

Merged
merged 2 commits into from
Dec 30, 2020
Merged

model validation bug #15

merged 2 commits into from
Dec 30, 2020

Conversation

nadar
Copy link
Member

@nadar nadar commented Dec 30, 2020

this closes #14

*
* @return void
*/
public function submitAndStore()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function submitAndStore has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Dec 30, 2020

Code Climate has analyzed commit fc61e39 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.0% (0.1% change).

View more on Code Climate.

@nadar nadar merged commit 22b6beb into master Dec 30, 2020
@nadar nadar deleted the issue-14 branch December 30, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when summary step is disabled and a php validation rule fails
1 participant