RFC: Allow to setup an X11 event filter #49
Conversation
Signed-off-by: falkTX <falktx@falktx.com>
| @@ -1129,6 +1129,10 @@ dispatchX11Events(PuglWorld* const world) | |||
| continue; | |||
| } | |||
|
|
|||
| if (world->impl->eventFilter && world->impl->eventFilter(display, &xevent)) { | |||
| continue; | |||
There was a problem hiding this comment.
I don't get it. What is this concretely used for?
There was a problem hiding this comment.
injecting x11 event handling that runs on the same event loop.
the target is to couple pugl with https://github.com/x42/sofd/.
this runs on top of an existing x11 event loop to provide file dialogs with pure x11 calls.
for my old code I had it working alike this event filtering stuff.
I am not sure it is possible to make it work without placing it on top of pugl event loop.
but I can give this a try if you find this too intrusive.
There was a problem hiding this comment.
I see. "Filter" doesn't imply doing so much, to me.
As you predicted, I am not at all a fan of exposing XEvent in the Pugl API at all, but for such uses this seems to have another problem: it requires the use of static data? No world or view is passed, so there's no access to data to actually do anything with. Not having/requiring static data is a largely the point of Pugl existing at all, so I don't think that's appropriate (or something plugin UIs should be doing in general).
That said, I still don't quite get it. Doesn't sofd make its own window? Why can't it just handle its own events? Why does it need per-event access to events in a PuglView?
There was a problem hiding this comment.
Yes, there are some problems with it. the static data is one, but that can be easily avoided.
I will try to get this stuff working without messing up with core pugl code.
|
I have now implemented sofd in DPF without having to inject into the main loop of pugl, in DISTRHO/DPF@03d53ea |
This might be a bit controversial, but I found that I need this if I am going to not keep a forked pugl.
These changes allow to plug in other custom x11 code on top of pugl, that handles its own windows, events etc.
Tested to work with DPF and https://github.com/x42/sofd/
I tried to make it as generic as possible.