Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelation of timers does not work. #28

Open
tice17 opened this issue Jan 1, 2024 · 9 comments
Open

Cancelation of timers does not work. #28

tice17 opened this issue Jan 1, 2024 · 9 comments

Comments

@tice17
Copy link

tice17 commented Jan 1, 2024

Hi,

I created diagnosis 00058206-0eaf-4f49-8a2a-d5bd2b25ccac. I have a simple flow that, when started, should cancel two running timers. The timers are NOT canceled like they should.

@stofferr
Copy link

stofferr commented Jul 14, 2024

Same issue. Even though my timer is cancelled, the light turns on again. Will we be able to expect a fix please?

@stofferr
Copy link

Also in the timers list, timers seem to disappear automatically after a few seconds after starting, but they are still running.
This may also be the cause for timers to not being cancelled as they are no longer in the list.

@lvanderree
Copy link
Owner

Hmmm that is interesting. I haven't had this issue myself, but I will try to take a look at it, try if I can reproduce it myself.

I store a reference to all timers that are started here: https://github.com/lvanderree/com.synplyworks.thenmore/blob/master/app.js#L183C4-L183C11 So if the timer is dissapears from the list, it is supposed to have stopped, since besides cancelling that is the only reason to get removed from the list: https://github.com/lvanderree/com.synplyworks.thenmore/blob/master/app.js#L178

Maybe you can share more info about your flow, to make it possible to reproduce it for me...

@shaarkys
Copy link

Also in the timers list, timers seem to disappear automatically after a few seconds after starting

Probably similar issue to #26 (comment) ?

@stofferr
Copy link

stofferr commented Jul 15, 2024 via email

@stofferr
Copy link

stofferr commented Jul 15, 2024 via email

@stofferr
Copy link

stofferr commented Jul 15, 2024 via email

@stofferr
Copy link

stofferr commented Jul 15, 2024 via email

@stofferr
Copy link

I created this flow:
image

The first time I ran it, it worked flawlessly.
The second time I ran it, on both timer start cards, for each, after 2-3 seconds, the timer automagically disappears.

DiagID: a6807319-a366-41d4-8790-8ced8f79a76c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants