Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to set SDL window title from lv_drv_conf.h #277

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

hanhsuan
Copy link
Contributor

@hanhsuan hanhsuan commented Apr 4, 2023

I'm trying to use LVGL and SDL to write one cross platform GUI application, but the window title for SDL is hardcode in the sdl.c. Therefore, it would be nice to have a way to set SDL window title from lv_drv_conf.h just as other setting.

@kisvegabor
Copy link
Member

It's ok, but please add an

#ifndef SDL_WINDOW_TITLE
#define SDL_WINDOW_TITLE "TFT Simulator"
#endif

in sdl.c.

Note that, we have already moved the SDL driver to LVGL master branch. When LVGL v9 will be released this repository will be detracted. So it might be worth adding the same feature in LVGL master too.

@hanhsuan
Copy link
Contributor Author

hanhsuan commented Apr 4, 2023

I will go to add this feature to the LVGL master. Thanks a lot for your notice.

@hanhsuan
Copy link
Contributor Author

Should I follow what lvgl v9 to modify this PR, or close ?

@kisvegabor
Copy link
Member

Sorry for the delay.

This repo mostly uses define based configurations we can keep it as it is.

Merging

@kisvegabor kisvegabor merged commit 57494ff into lvgl:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants