Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple byte characters filename support #24

Closed
fralonra opened this issue Aug 17, 2022 · 1 comment
Closed

Multiple byte characters filename support #24

fralonra opened this issue Aug 17, 2022 · 1 comment

Comments

@fralonra
Copy link
Contributor

fralonra commented Aug 17, 2022

According to Automattic/node-canvas#1802

node-canvas doesn't handle multi-byte characters in filenames properly.

This means that the image path could not contain any Chinese/Japanese/Korean characters.
(But only failed on Windows. Related: tnfe/FFCreator#3)

I'm wondering It there workaround without modifying the image path?

@fralonra fralonra changed the title Multiple byte filenames filename support Multiple byte characters filename support Aug 17, 2022
@embeddedt
Copy link
Member

I would rather just add a note to the README advising that you need to rename these files before passing them to the converter. I suspect this is not the only tool with the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants