Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI test for Windows build #5904

Closed
kisvegabor opened this issue Mar 18, 2024 · 4 comments
Closed

Add CI test for Windows build #5904

kisvegabor opened this issue Mar 18, 2024 · 4 comments

Comments

@kisvegabor
Copy link
Member

Introduce the problem

We have some warnings shown only MSVC.

Proposal

It's would be nice to set up a Window CI as well.

@lvgl-bot
Copy link

lvgl-bot commented Apr 2, 2024

We need some feedback on this issue.

Now we mark this as "stale" because there was no activity here for 14 days.

Remove the "stale" label or comment else this will be closed in 7 days.

@lvgl-bot lvgl-bot added the stale label Apr 2, 2024
@kisvegabor
Copy link
Member Author

Not stale

@liamHowatt
Copy link
Collaborator

I have opened a PR for building on Windows with GCC which supports windows.h and contains exceptions to the standard such as _aligned_malloc found in MSVC. #6015. This can be a starting point for using MSVC. It may be simple to use MSVC in CMake, but I do not know for certain, and wanted to establish some progress in the right direction in case MSVC is not trivial to use in CMake. cl.exe is the compiler that'd be invoked at each build step.

Since we just want to build for now, it might be simpler to maintain a build script (?) separate from CMake for MSVC.

@kisvegabor
Copy link
Member Author

Great! Let's continue in the PR! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants